fix: reject profile photos bigger than 1MB #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1377--dhis2-user-profile.netlify.app |
tomzemp
approved these changes
Dec 11, 2023
kabaros
force-pushed
the
DHIS2-10828/limit-avatar-size
branch
from
ff59846 to
ba0c55c
Compare
KaiVandivier
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Nice 👍
(For posterity, here's some discussion about the file size)
kabaros
force-pushed
the
DHIS2-10828/limit-avatar-size
branch
from
ba0c55c to
5d2a203
Compare
|
🎉 This PR is included in version 30.4.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets a maximum size of 1MB for profile photos uploads. Fixes DHIS2-10828.