Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twofactor design changes #1245

Merged

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Feb 24, 2023

This PR makes changes to the two-factor authentication feature being refactored/reintroduced in #1244.

Change summary:

  • Use terminology two-factor authentication consistently.
  • Adjust use of NoticeBox vs. Tag to show current status.
  • Add introductory text.
  • Adjust texts and labels.
  • Various design / layout changes.

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1245--dhis2-user-profile.netlify.app

@HendrikThePendric HendrikThePendric merged commit 283d471 into DHIS2-14555-update-2fa-image-source Feb 27, 2023
@HendrikThePendric HendrikThePendric deleted the 2fa-design-changes branch February 27, 2023 15:06
HendrikThePendric added a commit that referenced this pull request Feb 27, 2023
* fix: adjust qr image source to new 2fa endpoint

* chore: remove debug header

* chore: remove legacy husky file

* chore: update dependencies

* feat: adjust 2fa configuration ui to new endpoint

* refactor: variable renaming

* chore: upgrade node on ci

* chore: remove redundant action

* feat: toggle 2fa using the enter key

* chore: fix typos

* fix: address pr comments

* fix: use div instead of header element

* fix: adjust apple store url and link rel attributes

* fix: twofactor design changes (#1245)

* fix: twofactor design changes

* chore: fix i18n

---------

Co-authored-by: HendrikThePendric <[email protected]>

---------

Co-authored-by: Joe Cooper <[email protected]>
dhis2-bot added a commit that referenced this pull request Feb 27, 2023
## [30.3.30](v30.3.29...v30.3.30) (2023-02-27)

### Bug Fixes

* adjust 2fa configuration ui to new api ([#1244](#1244)) ([84a04e1](84a04e1)), closes [#1245](#1245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants