Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): remove testing-library from selector bar prod deps #1648

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

KaiVandivier
Copy link
Contributor

Noticed this when examining testing-library deps in the app platform alpha:

sharing-dialog-testing-library-upgraded

It shouldn't be necessary here; there's a dev dependency at the package root

@KaiVandivier KaiVandivier requested a review from a team as a code owner December 5, 2024 12:09
Copy link

sonarqubecloud bot commented Dec 5, 2024

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1648--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 5, 2024 12:13 Inactive
@KaiVandivier KaiVandivier requested a review from a team December 5, 2024 12:52
@KaiVandivier KaiVandivier merged commit e8ea894 into master Dec 5, 2024
18 checks passed
@KaiVandivier KaiVandivier deleted the fix-deps-testing-library-in-prod branch December 5, 2024 13:36
dhis2-bot added a commit that referenced this pull request Dec 5, 2024
## [10.1.7](v10.1.6...v10.1.7) (2024-12-05)

### Bug Fixes

* **deps:** remove testing-library from selector-bar prod deps ([#1648](#1648)) ([e8ea894](e8ea894))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants