feat(tooltip): accessibility improvements for tooltip #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #3324 ↗︎
Details:
Review all test suite changes for PR #1463 ↗︎ |
|||||||||||||||
|
🚀 Deployed on https://pr-1463--dhis2-ui.netlify.app |
kabaros
requested changes
Mar 19, 2024
There was a problem hiding this comment.
the PR loooks good @alaa-yahia - there is a failing test though, and linting failure which you need to fix (yarn format --fix should do it, I think)
kabaros
reviewed
Mar 19, 2024
kabaros
approved these changes
Mar 19, 2024
dhis2-bot
added a commit
that referenced
this pull request
Mar 19, 2024
# [9.5.0-alpha.1](v9.4.2...v9.5.0-alpha.1) (2024-03-19) ### Features * splitButton accessibility improvements ([#1458](#1458)) ([51a1b14](51a1b14)) * **tooltip:** accessibility improvements for tooltip ([#1463](#1463)) ([f11eabb](f11eabb)) * add aria attributes to loaders ([#1449](#1449)) ([2832584](2832584))
kabaros
pushed a commit
that referenced
this pull request
Jun 3, 2024
* feat(tooltip): accessibility improvements for tooltip * fix(tooltip): solve failing test
dhis2-bot
added a commit
that referenced
this pull request
Jun 3, 2024
# [9.7.0](v9.6.0...v9.7.0) (2024-06-03) ### Bug Fixes * **Tooltip:** add missing tabIndex ([389e61a](389e61a)) ### Features * splitButton accessibility improvements ([#1458](#1458)) ([8370915](8370915)) * **tooltip:** accessibility improvements for tooltip ([#1463](#1463)) ([9afcfdf](9afcfdf)) * add aria attributes to loaders ([#1449](#1449)) ([aaa60fb](aaa60fb)) * add optional aria-label prop to switch component ([bf9927a](bf9927a))
alaa-yahia
added a commit
that referenced
this pull request
Jun 10, 2024
* feat(tooltip): accessibility improvements for tooltip * fix(tooltip): solve failing test
alaa-yahia
pushed a commit
that referenced
this pull request
Jun 10, 2024
* **Tooltip:** add missing tabIndex ([389e61a](389e61a)) * splitButton accessibility improvements ([#1458](#1458)) ([8370915](8370915)) * **tooltip:** accessibility improvements for tooltip ([#1463](#1463)) ([9afcfdf](9afcfdf)) * add aria attributes to loaders ([#1449](#1449)) ([aaa60fb](aaa60fb)) * add optional aria-label prop to switch component ([bf9927a](bf9927a))
dhis2-bot
added a commit
that referenced
this pull request
Jun 17, 2024
# [9.9.0-alpha.1](v9.8.1...v9.9.0-alpha.1) (2024-06-17) ### Features * splitButton accessibility improvements ([#1458](#1458)) ([51a1b14](51a1b14)) * **tooltip:** accessibility improvements for tooltip ([#1463](#1463)) ([f11eabb](f11eabb)) * add aria attributes to loaders ([#1449](#1449)) ([2832584](2832584)) ### Reverts * Revert "feat(selectionBar): accessibility improvements for SelectionBar (#1475)" ([54498fb](54498fb)), closes [#1475](#1475)
dhis2-bot
added a commit
that referenced
this pull request
Sep 23, 2024
# [9.12.0-alpha.1](v9.11.4...v9.12.0-alpha.1) (2024-09-23) ### Bug Fixes * bump multi calendar library version in calendar ([#1566](#1566)) ([d205016](d205016)) * bump multi calendar library version in calendar component ([#1576](#1576)) ([5f2b13d](5f2b13d)) * update yarn.lock after deduping ([5c24b02](5c24b02)) ### Features * add aria attributes to loaders ([#1449](#1449)) ([2832584](2832584)) * memorize calendar container component to improve perfromance ([#1575](#1575)) ([0d00a19](0d00a19)) * merge master into alpha ([7afecf9](7afecf9)) * splitButton accessibility improvements ([#1458](#1458)) ([51a1b14](51a1b14)) * support editable input | min & max dates | dd-mm-yyyy format in CalendarInput ([#1504](#1504)) ([99a78f5](99a78f5)) * use alpha of multi calendar library ([0c6b966](0c6b966)) * verify date input only on blur on calendar input, close calendar popup on blur as well ([d8b0d1c](d8b0d1c)) * **tooltip:** accessibility improvements for tooltip ([#1463](#1463)) ([f11eabb](f11eabb)) ### Reverts * Revert "feat(selectionBar): accessibility improvements for SelectionBar (#1475)" ([54498fb](54498fb)), closes [#1475](#1475)
dhis2-bot
added a commit
that referenced
this pull request
Nov 21, 2024
# [10.0.0](v9.15.0...v10.0.0) (2024-11-21) ### Bug Fixes * update calendar tests for react 18 ([98831a7](98831a7)) * update testing-library for selector-bar ([893024d](893024d)) * **calendar:** fix minor type issues ([#1588](#1588)) ([21e60a6](21e60a6)) * **calendar:** stop extra call to validation when choosing from picker ([#1623](#1623)) ([a1786d5](a1786d5)) * **calendar-input:** trigger onFocus if passed ([#1622](#1622)) ([293505d](293505d)) * bump multi calendar library version in calendar ([#1566](#1566)) ([d205016](d205016)) * bump multi calendar library version in calendar component ([#1576](#1576)) ([5f2b13d](5f2b13d)) * bump multi-calendar library ([#1615](#1615)) ([238de1f](238de1f)) * bump multi-calendar library ([#1618](#1618)) ([769c7ae](769c7ae)) * clear button and arrow alignment issues ([#1609](#1609)) ([ba0b657](ba0b657)) * stories for calendar validation ([#1616](#1616)) ([c00a2d6](c00a2d6)) * update multi-calendar library ([6aa01cc](6aa01cc)) * update yarn.lock after deduping ([5c24b02](5c24b02)) ### Features * add aria attributes to loaders ([#1449](#1449)) ([2832584](2832584)) * calendar input to work with react final form ([827c3f8](827c3f8)) * memorize calendar container component to improve perfromance ([#1575](#1575)) ([0d00a19](0d00a19)) * merge branch master into branch ([0577074](0577074)) * merge master into alpha ([7afecf9](7afecf9)) * splitButton accessibility improvements ([#1458](#1458)) ([51a1b14](51a1b14)) * support editable input | min & max dates | dd-mm-yyyy format in CalendarInput ([#1504](#1504)) ([99a78f5](99a78f5)) * use alpha of multi calendar library ([0c6b966](0c6b966)) * verify date input only on blur on calendar input, close calendar popup on blur as well ([d8b0d1c](d8b0d1c)) * **tooltip:** accessibility improvements for tooltip ([#1463](#1463)) ([f11eabb](f11eabb)) ### Reverts * Revert "feat(selectionBar): accessibility improvements for SelectionBar (#1475)" ([54498fb](54498fb)), closes [#1475](#1475) ### BREAKING CHANGES * multi-calendar hook no longer returns Temporal date * fix: failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-558
Description
Tooltip has role="tooltip"
Tooltip is shown when trigger element receives keyboard focus.
Tooltip itself can be hovered. Tooltip closes when either the trigger element or the Tooltip are no longer hovered, or the trigger element is no longer focused.
Tooltip can be closed by pressing the
esckey.Trigger element reference tooltip with
aria-describedby.Known issues
closeDelayis set tozero.Checklist