Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: debounce the item selector query in dashboard editor [DHIS2-10530] #1554

Merged
merged 5 commits into from
Feb 22, 2021
Merged

fix: debounce the item selector query in dashboard editor [DHIS2-10530] #1554

merged 5 commits into from
Feb 22, 2021

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Feb 19, 2021 •
edited
Loading

Fix:

  • prevent the item selector query from firing on every keystroke.

Refactor:

  • useDataEngine instead of manually constructing the query
  • SinglesMenuGroup exports was triggering eslint warning, so no longer export const SinglesMenuGroup (unit test had to be updated)
  • remove USERS from ItemSelector as it is no longer meant to be used (confirmed with @janhenrikoverland )
  • borrow the useDebounce hook from analytics. Have suggested to Austin that it could be added to app-runtime

janhenrikoverland
janhenrikoverland approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@janhenrikoverland janhenrikoverland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when comment is resolved.

@jenniferarnesen jenniferarnesen merged commit 349b305 into master Feb 22, 2021
@jenniferarnesen jenniferarnesen deleted the fix/debounce-item-selector branch February 22, 2021 09:53
dhis2-bot added a commit that referenced this pull request Feb 22, 2021
@dhis2-bot
chore(release): cut 31.12.2 [skip ci]
5534b26 
## [31.12.2](v31.12.1...v31.12.2) (2021-02-22)

### Bug Fixes

* debounce the item selector query in dashboard editor [DHIS2-10530] ([#1554](#1554)) ([349b305](349b305))
* upgrade to ui6 and set resolutions ([#1557](#1557)) ([a065cd3](a065cd3))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 31.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooper-joe cooper-joe cooper-joe left review comments

@janhenrikoverland janhenrikoverland janhenrikoverland approved these changes

@edoardo edoardo Awaiting requested review from edoardo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenniferarnesen @dhis2-bot @janhenrikoverland @cooper-joe