fix: make space to left of dashboard items scrollable [DHIS2-10138] #1523
Conversation
…ashboard-app into fix/print-scrollable-left-margin
| const { width } = useWindowDimensions() | ||
| const isSmall = isSmallScreen(width) | ||
| const getExitPrintButton = isSmall => { | ||
| const className = isSmall ? classes.buttonSmall : classes.buttonWide |
There was a problem hiding this comment.
I'm not sure what the best naming convention is, but could we possibly use small - large or maybe narrow - wide? small - wide sound like two different properties to me (however your English is better than mine so I could be wrong).
There was a problem hiding this comment.
I'd also consider moving the ternary operator directly into the className={ ... } to reduce the footprint a bit.
| @media print { | ||
| .wrapper { | ||
| .container { | ||
| background-color: white; | ||
| height: auto !important; |
There was a problem hiding this comment.
Probably out of scope, but I noticed these !important. media -> class should override any class selector, so are these really necessary?
There was a problem hiding this comment.
I've been starting to review a lot of the css and I'll make a note to look at this one. Thanks!
| background-color: white; | ||
| height: auto !important; | ||
| overflow: visible !important; | ||
| margin-left: 0px; | ||
| padding-left: 0px; |
There was a problem hiding this comment.
Also not in scope, and it has no production code impact, but my personal preference is to use 0 instead of 0px. This is just my OCD speaking, so disregard this if you have a different opinion 😄
## [31.10.9](v31.10.8...v31.10.9) (2021-02-12) ### Bug Fixes * add css class for expanded control bar ([286c1ae](286c1ae)) * clean dashboard bar height calculation function ([71bb64d](71bb64d)) * make space to left of dashboard items scrollable [DHIS2-10138] ([#1523](#1523)) ([3305aa3](3305aa3)) * remove inline style calculation height for small, dashboardbar chip container and controlbar ([99dea63](99dea63)) * update dashboard bar snapshot ([1caac43](1caac43))
|
🎉 This PR is included in version 31.10.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes:
scrolling.mov