Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with angular 8 #181

Closed
floAtEbcont opened this issue May 28, 2020 · 2 comments
Closed

Errors with angular 8 #181

floAtEbcont opened this issue May 28, 2020 · 2 comments

Comments

@floAtEbcont
Copy link

Running/Building a default angular <= 8 project with ngx-ui-scroll >= 1.6.4 fails with the error An accessor cannot be declared in an ambient context.

The cause for this is being discussed here: microsoft/TypeScript#33939

For my own libs, I fixed this by just downgrading to [email protected] before bundling the lib and pushing it to npm.
Or - if you decide to no longer support angular < 9 - you could update your lib's peer dependencies accordingly.

@dhilt
Copy link
Owner

dhilt commented May 29, 2020

Terrible story... Thanks a lot for the report and suggestions. I published ngx-ui-scroll v1.6.6 on npm with downgraded typescript. Could you confirm it works in your environment?

@floAtEbcont
Copy link
Author

Yes! Version 1.6.6. works fine in angular 8. 🥳 Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants