fix: checking generated api key #1589
Conversation
| @@ -906,9 +906,11 @@ export default class HttpServer { | |||
| const apiKey = createApiKey() | |||
|
|
|||
| this.#apiKeysValues = getApiKeysValues( | |||
| this.#serverless.service.provider.apiGateway?.apiKeys ?? [apiKey], | |||
There was a problem hiding this comment.
This doesn't work correctly. The result of this expression is that this.#apiKeysValues is an empty set which means the key that was just created will not work.
There was a problem hiding this comment.
yes, you are right. the problem is that we are passing the result of the expression to getApiKeysValues, which expects an array of objects, while [apiKey] is just an array of a string.
| ) | ||
|
|
||
| this.#apiKeysValues.push(apiKey) |
There was a problem hiding this comment.
getApiKeysValues is returning a Set, where push does not exist. we would need to use .add here. ideally we would only push when we have no values in the Set. and ideally we would only then call createApiKey.
|
thank you for your PR @iansu !
I'll pull this in and fix this up so we can release it quickly.
I wanted to add a test for this initially, but couldn't find the time. in the test we would need to read the generated key from stdout. |
Description
A recent change prevented the default generated API key from working: https://github.com/dherault/serverless-offline/pull/1585/files#diff-c2aeb87128097ca7cd2056b14fba597e31a08404b3bedd046fb550ca602147a3L925
Motivation and Context
Fix a bug that was recently introduced and shipped in v11
How Has This Been Tested?
I've tested this fix locally. This probably should have been covered by a unit test to prevent this from breaking originally. I can add some better tests if that's desired. I figure you probably want to ship a patch release with this fix soon though.
Screenshots (if appropriate):
N/A