From 5026b5b224be16c6031b87b9ece6726431e2bffb Mon Sep 17 00:00:00 2001
From: Andrew Baptist <baptist@cockroachlabs.com>
Date: Wed, 20 Nov 2024 12:50:44 -0500
Subject: [PATCH] roachtest: create perturbation/*/backup tests

Add a backup perturbation test. This test will run a backup as the
perturbation. For normal cases the impact of backup appears to be
minimal so I'm setting the passing criteria to 5.0. We can revisit if
this test becomes flaky.

Epic: none

Release note: None
---
 .../roachtest/tests/perturbation/BUILD.bazel  |  2 +
 .../roachtest/tests/perturbation/backup.go    | 68 +++++++++++++++++++
 .../roachtest/tests/perturbation/framework.go |  1 +
 3 files changed, 71 insertions(+)
 create mode 100644 pkg/cmd/roachtest/tests/perturbation/backup.go

diff --git a/pkg/cmd/roachtest/tests/perturbation/BUILD.bazel b/pkg/cmd/roachtest/tests/perturbation/BUILD.bazel
index 1ef4ca9d473d..2ce2e0f83bde 100644
--- a/pkg/cmd/roachtest/tests/perturbation/BUILD.bazel
+++ b/pkg/cmd/roachtest/tests/perturbation/BUILD.bazel
@@ -4,6 +4,7 @@ go_library(
     name = "perturbation",
     srcs = [
         "add_node.go",
+        "backup.go",
         "decommission.go",
         "elastic_workload.go",
         "framework.go",
@@ -25,6 +26,7 @@ go_library(
         "//pkg/cmd/roachtest/test",
         "//pkg/roachprod/install",
         "//pkg/roachprod/logger",
+        "//pkg/testutils",
         "//pkg/util/randutil",
         "//pkg/util/retry",
         "//pkg/util/timeutil",
diff --git a/pkg/cmd/roachtest/tests/perturbation/backup.go b/pkg/cmd/roachtest/tests/perturbation/backup.go
new file mode 100644
index 000000000000..2b05be11093c
--- /dev/null
+++ b/pkg/cmd/roachtest/tests/perturbation/backup.go
@@ -0,0 +1,68 @@
+// Copyright 2024 The Cockroach Authors.
+//
+// Use of this software is governed by the CockroachDB Software License
+// included in the /LICENSE file.
+
+package perturbation
+
+import (
+	"context"
+	"fmt"
+	"math/rand"
+	"strconv"
+	"time"
+
+	"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec"
+	"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test"
+	"github.com/cockroachdb/cockroach/pkg/testutils"
+	"github.com/cockroachdb/cockroach/pkg/util/timeutil"
+	"github.com/stretchr/testify/require"
+)
+
+// backup will run a backup during the perturbation phase.
+type backup struct{}
+
+var _ perturbation = backup{}
+
+func (b backup) setup() variations {
+	return setup(b, 5.0)
+}
+
+// TODO(baptist): Add variation for incremental backup.
+// TODO(baptist): Add variation with revision history.
+func (b backup) setupMetamorphic(rng *rand.Rand) variations {
+	return b.setup().randomize(rng)
+}
+
+func (backup) startTargetNode(ctx context.Context, t test.Test, v variations) {
+	v.startNoBackup(ctx, t, v.targetNodes())
+}
+
+func (backup) startPerturbation(ctx context.Context, t test.Test, v variations) time.Duration {
+	startTime := timeutil.Now()
+	db := v.Conn(ctx, t.L(), v.targetNodes()[0])
+	defer db.Close()
+	var bucketPrefix string
+	backupTestingBucket := testutils.BackupTestingBucket()
+	switch v.Cloud() {
+	case spec.GCE:
+		bucketPrefix = "gs"
+	case spec.AWS:
+		bucketPrefix = "s3"
+	case spec.Azure:
+		bucketPrefix = "azure"
+	default:
+		bucketPrefix = "nodelocal"
+		backupTestingBucket = strconv.Itoa(v.targetNodes()[0])
+	}
+	backupURL := fmt.Sprintf("%s://%s/perturbation-backups/%s?AUTH=implicit", bucketPrefix, backupTestingBucket, v.Name())
+	cmd := fmt.Sprintf(`BACKUP INTO '%s' AS OF SYSTEM TIME '-10s'`, backupURL)
+	_, err := db.ExecContext(ctx, cmd)
+	require.NoError(t, err)
+	return timeutil.Since(startTime)
+}
+
+func (backup) endPerturbation(ctx context.Context, t test.Test, v variations) time.Duration {
+	waitDuration(ctx, v.validationDuration)
+	return v.validationDuration
+}
diff --git a/pkg/cmd/roachtest/tests/perturbation/framework.go b/pkg/cmd/roachtest/tests/perturbation/framework.go
index 78eed03393af..bedf85d5603b 100644
--- a/pkg/cmd/roachtest/tests/perturbation/framework.go
+++ b/pkg/cmd/roachtest/tests/perturbation/framework.go
@@ -270,6 +270,7 @@ func RegisterTests(r registry.Registry) {
 	register(r, &slowDisk{})
 	register(r, elasticWorkload{})
 	register(r, intents{})
+	register(r, backup{})
 }
 
 func (v variations) makeClusterSpec() spec.ClusterSpec {