From d7db863e9a6b5676dbb7b037dc8776de683a3e0a Mon Sep 17 00:00:00 2001 From: mwish Date: Fri, 20 Oct 2023 00:43:45 +0800 Subject: [PATCH] GH-38117: [C++][Parquet] Change DictEncoder dtor checking to warning log (#38118) ### Rationale for this change This is a minor change, just change `DCHECK` to warning log. ### What changes are included in this PR? change `DCHECK` to warning log. ### Are these changes tested? no, I don't know how to test this, any idea is welcome. ### Are there any user-facing changes? no * Closes: #38117 Authored-by: mwish Signed-off-by: Antoine Pitrou --- cpp/src/parquet/encoding.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/parquet/encoding.cc b/cpp/src/parquet/encoding.cc index c136671bd1327..5221f2588c0d3 100644 --- a/cpp/src/parquet/encoding.cc +++ b/cpp/src/parquet/encoding.cc @@ -442,7 +442,7 @@ class DictEncoderImpl : public EncoderImpl, virtual public DictEncoder { dict_encoded_size_(0), memo_table_(pool, kInitialHashTableSize) {} - ~DictEncoderImpl() override { DCHECK(buffered_indices_.empty()); } + ~DictEncoderImpl() = default; int dict_encoded_size() const override { return dict_encoded_size_; }