Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neeraj/v20.03 pagination uid #6631

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Conversation

antblood
Copy link
Contributor

@antblood antblood commented Oct 2, 2020

Pagination param "after" does not work when using func: uid(v)

for query

{
  var(func: has(name@en), first: 50) {
    test as uid
  }

  ss(func: uid(test), first: 2, after: 0x6) {
    uid
  }
}

the response was

{
  "data": {
    "ss": [
      {
        "uid": "0x4"
      },
      {
        "uid": "0x6"
      }
    ]
  }
}

This change is Reviewable

Docs Preview: Dgraph Preview

fixed : Pagination param "after" does not work when using func: uid(v)
(cherry picked from commit 732732b)
@antblood antblood changed the base branch from master to release/v20.03 October 2, 2020 19:52
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 rules errored during the review.

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the code but it's a cherry-pick so LGTM

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @danielmai, @manishrjain, @martinmr, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)

@antblood antblood merged commit 555aab6 into release/v20.03 Oct 3, 2020
@joshua-goldstein joshua-goldstein deleted the neeraj/v20.03-paginationUID branch August 11, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants