release/v1.2 - Feat(Dgraph): Add separate compression flag for z and wal dirs (#6401) #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add separate compression flag for z and wal dirs * Address comments * Address comments (cherry picked from commit 601cc3b)
vmrajas
changed the title
jarifibrahim
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, badger.compression_level flag is used to set compression level for Postings directory. Compression Level for WAL directory is set to None by default.
This PR adds functionality to set compression levels of each directory separately using a comma separated badger.compression_level flag.
Related discuss issue: https://discuss.dgraph.io/t/separate-dgraph-compression-level-config-for-p-and-w-directories/9938
Components affected by this PR:
Dgraph alpha
Does this PR break backwards compatibility?:
No
Fixes DGRAPH-2380
(cherry picked from commit 601cc3b)
This change is
Docs Preview: