Add Badger expvar metrics to Prometheus metrics. #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
changed the title
martinmr
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
prashant-shahi
approved these changes
Apr 5, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
There was a problem hiding this comment.
We've renamed the metrics in badger and PR #5216 updates badger in dgraph. The metric names will have to be updated once PR #5216 is merged.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @manishrjain, @martinmr, and @prashant-shahi)
The test now finds metric names that have a number in the name. e.g., badger_v2_disk_reads_total.
danielmai
added a commit
that referenced
this pull request
Apr 24, 2020
Fixes #4772 This adds the following badger metrics into /debug/prometheus_metrics: badger_v2_disk_reads_total badger_v2_disk_writes_total badger_v2_gets_total badger_v2_lsm_bloom_hits_total (per level) badger_v2_lsm_level_gets_total (per level) badger_v2_memtable_gets_total badger_v2_puts_total badger_v2_read_bytes badger_v2_written_bytes This is added via the Prometheus expvar collector. Update metrics_test.go for the seven initial Badger versions (excluding the LSM metrics). This adds to the exposed Prometheus metrics. These metrics were already accessible via /debug/vars. The LSM metrics don't show up immediately. They show up after there are hits/gets to the LSM tree. Changes * Add Badger metrics to Prometheus * Update metrics test to check for badger metrics. Co-authored-by: Ibrahim Jarif <[email protected]>
danielmai
added a commit
that referenced
this pull request
Apr 24, 2020
Fixes #4772 This adds the following badger metrics into /debug/prometheus_metrics: badger_v2_disk_reads_total badger_v2_disk_writes_total badger_v2_gets_total badger_v2_lsm_bloom_hits_total (per level) badger_v2_lsm_level_gets_total (per level) badger_v2_memtable_gets_total badger_v2_puts_total badger_v2_read_bytes badger_v2_written_bytes This is added via the Prometheus expvar collector. Update metrics_test.go for the seven initial Badger versions (excluding the LSM metrics). This adds to the exposed Prometheus metrics. These metrics were already accessible via /debug/vars. The LSM metrics don't show up immediately. They show up after there are hits/gets to the LSM tree. Changes * Add Badger metrics to Prometheus * Update metrics test to check for badger metrics. Co-authored-by: Ibrahim Jarif <[email protected]>
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Fixes hypermodeinc#4772 This adds the following badger metrics into /debug/prometheus_metrics: badger_v2_disk_reads_total badger_v2_disk_writes_total badger_v2_gets_total badger_v2_lsm_bloom_hits_total (per level) badger_v2_lsm_level_gets_total (per level) badger_v2_memtable_gets_total badger_v2_puts_total badger_v2_read_bytes badger_v2_written_bytes This is added via the Prometheus expvar collector. Update metrics_test.go for the seven initial Badger versions (excluding the LSM metrics). This adds to the exposed Prometheus metrics. These metrics were already accessible via /debug/vars. The LSM metrics don't show up immediately. They show up after there are hits/gets to the LSM tree. Changes * Add Badger metrics to Prometheus * Update metrics test to check for badger metrics. Co-authored-by: Ibrahim Jarif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the following badger metrics into /debug/prometheus_metrics:
badger_v2_disk_reads_totalbadger_v2_disk_writes_totalbadger_v2_gets_totalbadger_v2_lsm_bloom_hits_total(per level)badger_v2_lsm_level_gets_total(per level)badger_v2_memtable_gets_totalbadger_v2_puts_totalbadger_v2_read_bytesbadger_v2_written_bytesChanges:
Motivation
For #4772.
Components affected by this PR
This adds to the exposed Prometheus metrics. These metrics were already accessible via /debug/vars.
Does this PR break backwards compatibility?
No.
Fixes
#4772
More
The LSM metrics don't show up immediately. They show up after there are hits/gets to the LSM tree.
This change is
Docs Preview: