Allow overwriting values of predicates of type uid #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When introducing the single uid type, mutations to those predicates were disallowed to prevent existing users from losing data due to the change in syntax. This PR introduces a flag to override that behavior and allow values to be overwritten directy instead of requiring a delete and an add operation.
manishrjain
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
How about skipping the flag? And changing the behavior slightly? That's what we do for setting string values and all, right?
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
martinmr
commented
Dec 18, 2019
There was a problem hiding this comment.
Uid values are now overwritten by default.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)
martinmr
changed the title
danielmai
pushed a commit
that referenced
this pull request
Jan 12, 2020
When introducing the single uid type, mutations to those predicates were disallowed to prevent existing users from losing data due to the change in syntax. This PR changes the behavior to allow values to be overwritten directy instead of requiring a delete and an add operation. (cherry picked from commit 45a6d5b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing the single uid type, mutations to those predicates were
disallowed to prevent existing users from losing data due to the change
in syntax.
This PR changes the behavior to allow values to be overwritten directy instead
of requiring a delete and an add operation.
This change is