release/v1.0: Vendor in Badger release/v1.6 branch for discard stats bug fix. #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This vendors in Badger v1.6.0 with dgraph-io/badger#929 cherry-picked into it (dgraph-io/badger#1098) to avoid any breaking changes to the data format. Vendor in Badger to fix a bug that prevents Alpha from starting up successfully. This happens in v1.0.16 and v1.0.17. Error while creating badger KV posting store error: Unable to find log file. Please retry The release/v1.0 branch uses the vendor directory for dependencies. Badger was pulled in with the following command: govendor fetch github.com/dgraph-io/badger/...@efb9d9d15d7f7baa656e04933058f006c33a8d0f
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
martinmr
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Reviewed 28 of 28 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendors in Badger v1.6.0 with dgraph-io/badger#929 cherry-picked
into it (dgraph-io/badger#1098) to avoid any breaking changes to the
data format.
This fixes a bug that prevents Alpha from starting
up successfully. This happens in v1.0.16 and v1.0.17.
The release/v1.0 branch uses the vendor directory for
dependencies. Badger was pulled in with the following command:
This change is