bump @grpc/grpc-js to a static version #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelDiz
approved these changes
Jan 13, 2023
Merged
shivaji-kharse
pushed a commit
that referenced
this pull request
Nov 5, 2024
Currently, the `grpc` dependency is causing the issue shown in issue #231 due to an incompatibility with the most recent version of `grpc` and any platform other than Linux based on our testing. We've also shown reports that the prebuilt binaries downloaded by `gprc` are causing massive bloat _**(nearly a 5x increase in size)**_ to our bundles that are generated with the dependency included. Upon investigation, we noticed that `grpc` isn't actually used by anything in the library anymore, and was seemingly [added back by mistake](#183) during the most recent release, as `@grpc/grpc-js` is used in place of it. Sources: [Original PR](#125) to remove `grpc` [PR I made last year](#164), where `grpc` was not in the list of dependencies at the time, reinforcing the fact that it was added back by mistake [The README of this very repo](https://github.com/dgraph-io/dgraph-js?tab=readme-ov-file#install), which has instructions to install `@grpc/grpc-js` and not `grpc`, and [here is the PR](#182) where that change was made This PR is to remove the `grpc` dependency from the package to accomplish the following: - remedy the installation issue - reduce install sizes - get rid of an unused dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug with
@grpc/grpc-jsv1.8.2, thedgraph-jslibrary fails to properly close GRPC calls causing mass failures across any applications utilizing this library to perform queries against DGraph.Since
dgraph-jsopts into patch version updates via the caret symbol^for this specific dependency, this caused an issue for any new deployments that utilize the package.This change is a suggestion to set the
@grpc/grpc-jsversion to a static1.8.1for the time being. A patch for this issue has already been deployed in v1.8.3 of the library, but we decided against utilizing this version until it has had time to be further tested and verified as working.This change is