Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ACL tests to sync up changes with Dgraph v1.2 #103

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

prashant-shahi
Copy link
Contributor

@prashant-shahi prashant-shahi commented Jan 29, 2020

  • Removed try..catch block from tryReading() function
  • Added tests for when no ACL permission passed
  • minor changes in a query for delete test to sort friends by name in ascending order

Signed-off-by: Prashant Shahi [email protected]


This change is Reviewable

- Removed try..catch block from tryReading() function
- Added tests for when there is no ACL permission is passed
- minor changes in delete tests' query to sort friends by name in ascending order

Signed-off-by: Prashant Shahi <[email protected]>
@prashant-shahi prashant-shahi merged commit 9762c1e into master Jan 30, 2020
@prashant-shahi prashant-shahi deleted the prashant/updating-acl-talks branch January 30, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants