-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: ristretto uses glog which breaks a lot of applications #1922
Comments
Gentle ping. This is quite annoying, and a fix seems not that complicated (as long as someone can commit dgraph-io/ristretto#293 ) |
Less gentle ping. 😇 This package is a 4th-degree dependency of my application. I'm surprised to see CLI flags and panics that are out of my control. This is bizarre to me as glog even states in its README that it's only for internal use at Google (why it is even public is beyond me):
Can we at least get some acknowledgement from @dgraph-io that this dependency will be removed? |
Ristretto has a change merged that removes glog. As soon as we do a new release, we should upgrade ristretto in badger. |
Just for the sake of better "full-text findability". Besides -alsologtostderr
log to standard error as well as files
-log_backtrace_at value
when logging hits line file:N, emit a stack trace
-log_dir string
If non-empty, write log files in this directory
-logtostderr
log to standard error instead of files
-stderrthreshold value
logs at or above this threshold go to stderr
-v value
log level for V logs
-vmodule value
comma-separated list of pattern=N settings for file-filtered logging |
Will this be addressed? I'd really like to get rid of the extra flags that are being added by using badger v4... EDIT: I found a way, you can declare your own flag set with |
This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
Please keep it open. |
What version of Badger are you using?
v4.0.1
What version of Go are you using?
Not relevant
Have you tried reproducing the issue with the latest release?
Yes
What is the hardware spec (RAM, CPU, OS)?
Not relevant
What steps will reproduce the bug?
Use badger in an app that has
-v
flag.Expected behavior and actual result.
Expected: program does not panic.
Actual: program panics.
This is because glog library pollutes flags and adds
-v
flag. This breaks every program that has-v
flag.Library should not pollute global flags.
Dependency graph
See relevant issues:
DataDog/dd-trace-go#1153
dgraph-io/ristretto#293
Additional information
Ristretto is abandoned and they will not remove glog dependency. Consider moving to ristretto fork.
The text was updated successfully, but these errors were encountered: