From 8c009fa3072586e74639542fcf89bbccef4612e9 Mon Sep 17 00:00:00 2001 From: Doug Parker Date: Sat, 18 Feb 2023 23:22:05 -0800 Subject: [PATCH] Adds load visibility to Jasmine Starlark code. Refs #67. --- tools/jasmine/defs.bzl | 2 ++ tools/jasmine/jasmine_node_test.bzl | 2 ++ tools/jasmine/jasmine_web_test_suite.bzl | 2 ++ 3 files changed, 6 insertions(+) diff --git a/tools/jasmine/defs.bzl b/tools/jasmine/defs.bzl index d8430a0d..e27fe806 100644 --- a/tools/jasmine/defs.bzl +++ b/tools/jasmine/defs.bzl @@ -4,5 +4,7 @@ load( _jasmine_web_test_suite = "jasmine_web_test_suite", ) +visibility("public") + jasmine_node_test = _jasmine_node_test jasmine_web_test_suite = _jasmine_web_test_suite diff --git a/tools/jasmine/jasmine_node_test.bzl b/tools/jasmine/jasmine_node_test.bzl index e8374b44..2f8946a8 100644 --- a/tools/jasmine/jasmine_node_test.bzl +++ b/tools/jasmine/jasmine_node_test.bzl @@ -3,6 +3,8 @@ load("@aspect_bazel_lib//lib:copy_file.bzl", "copy_file") load("@aspect_rules_jasmine//jasmine:defs.bzl", "jasmine_test") +visibility("private") + def jasmine_node_test(name, deps, data = [], size = "small", **kwargs): """Wrapper for the `jasmine_node_test()` rule. diff --git a/tools/jasmine/jasmine_web_test_suite.bzl b/tools/jasmine/jasmine_web_test_suite.bzl index d606fea8..a65f3a60 100644 --- a/tools/jasmine/jasmine_web_test_suite.bzl +++ b/tools/jasmine/jasmine_web_test_suite.bzl @@ -7,6 +7,8 @@ https://github.com/bazelbuild/rules_webtesting/blob/6b47a3f11b7f302c2620a3552cf8 load("@io_bazel_rules_webtesting//web:web.bzl", "web_test_suite") load(":jasmine_node_test.bzl", "jasmine_node_test") +visibility("private") + # Copied from https://github.com/bazelbuild/rules_webtesting/blob/6b47a3f11b7f302c2620a3552cf8eea8855e8c9e/web/internal/constants.bzl#L20-L45. # When a browser target name matches with one of these tags, they are used for # the generated `web_test()`.