From 11f6e9274b57e2d02404c3c4213a8f5fd70fe513 Mon Sep 17 00:00:00 2001 From: Doug Parker Date: Fri, 25 Jun 2021 23:28:11 -0700 Subject: [PATCH] Adds `tags` to `web_resources_devserver()`. This propagates the `tags` attribute to the underlying implementation. I initially tried to default `tags` to `None`, however this breaks `concatjs_devserver()`, which seems to expect to always receive a list. Instead, we have to default to `[]`. --- packages/rules_prerender/web_resources_devserver.bzl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/rules_prerender/web_resources_devserver.bzl b/packages/rules_prerender/web_resources_devserver.bzl index 602fa817..d62efb58 100644 --- a/packages/rules_prerender/web_resources_devserver.bzl +++ b/packages/rules_prerender/web_resources_devserver.bzl @@ -8,6 +8,7 @@ def web_resources_devserver( resources, testonly = None, visibility = None, + tags = [], ): """Generates a devserver which serves the provided `web_resources()` target. @@ -20,6 +21,7 @@ def web_resources_devserver( resources: The `web_resources()` target to serve. testonly: See https://docs.bazel.build/versions/master/be/common-definitions.html. visibility: See https://docs.bazel.build/versions/master/be/common-definitions.html. + tags: See https://docs.bazel.build/versions/master/be/common-definitions.html. """ # Generate a devserver implementation. concatjs_devserver( @@ -28,4 +30,5 @@ def web_resources_devserver( additional_root_paths = [file_path_of(absolute(resources))], testonly = testonly, visibility = visibility, + tags = tags, )