Skip to content

Commit

Permalink
goto_file: open picker if a directory is selected (helix-editor#7909)
Browse files Browse the repository at this point in the history
* feat: open file picker on directories using goto_file (gf)

* remove helper and call to canonicalize
  • Loading branch information
Andrés Cabero authored and dgkf committed Jan 30, 2024
1 parent a01af72 commit 92adddd
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion helix-term/src/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,11 @@ fn goto_file_impl(cx: &mut Context, action: Action) {
for sel in paths {
let p = sel.trim();
if !p.is_empty() {
if let Err(e) = cx.editor.open(&PathBuf::from(p), action) {
let path = Path::new(p);
if path.is_dir() {
let picker = ui::file_picker(path.into(), &cx.editor.config());
cx.push_layer(Box::new(overlaid(picker)));
} else if let Err(e) = cx.editor.open(path, action) {
cx.editor.set_error(format!("Open file failed: {:?}", e));
}
}
Expand Down Expand Up @@ -2603,6 +2607,7 @@ fn file_picker_in_current_buffer_directory(cx: &mut Context) {
let picker = ui::file_picker(path, &cx.editor.config());
cx.push_layer(Box::new(overlaid(picker)));
}

fn file_picker_in_current_directory(cx: &mut Context) {
let cwd = helix_loader::current_working_dir();
if !cwd.exists() {
Expand Down

0 comments on commit 92adddd

Please sign in to comment.