Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in example demo #684

Closed
Vishnuxx opened this issue Aug 21, 2023 · 2 comments · Fixed by #693, #715, #722 or #734
Closed

Bug in example demo #684

Vishnuxx opened this issue Aug 21, 2023 · 2 comments · Fixed by #693, #715, #722 or #734

Comments

@Vishnuxx
Copy link

I encountered a bug while testing the live demo of this library. The bug occurs when a list item is dragged and dropped exactly at the top of other list item in a specific manner. It seems like the dflex is creating additional unknown nodes to the list. Screenshots:
Screenshot 2023-08-21 at 8 56 32 PM
Screenshot 2023-08-21 at 8 57 15 PM
Screenshot 2023-08-21 at 9 29 58 PM

@jalal246
Copy link
Member

jalal246 commented Aug 25, 2023

@Vishnuxx Sorry to hear that you encountered a bug in the DFlex live demo. The screenshot you provided is very clear and does indicate a bug. However, I was unable to reproduce the bug myself.

DFlex does not change the DOM or mutate it. Instead, it reconciles when the drag ends.

There is an issue with Next.js client-side rendering when the store is handling multiple layouts across multiple routing pages. This is why I have reduced the demos to just two. To work around this issue, I should install the Next.js app and test DFlex there as an extra step to make sure that everything is working correctly. However, as Next.js is rapidly moving towards the app directory, I am not sure if I should continue this type of effort in this direction.

I will continue to investigate this bug and try to reproduce it. If I am able to do so, I will fix it and release a new version of DFlex.

@jalal246
Copy link
Member

jalal246 commented Nov 4, 2023

Hi @Vishnuxx, This issue appears to be resolved based on fixes in previous PRs #639, #715, #722, #734. The behavior described here is no longer happening. Please verify on your end, but likely this can be closed out now.

@jalal246 jalal246 closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment