Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2 error from dependency #184

Open
ghost opened this issue May 24, 2021 · 2 comments
Open

http2 error from dependency #184

ghost opened this issue May 24, 2021 · 2 comments

Comments

@ghost
Copy link

ghost commented May 24, 2021 •
edited by ghost
Loading

We've seen reports of the http2 error : protocol error : not a result of an error in our server logs for dfx users and it appears to be coming from the agent-rs dependency h2. See their issue here: hyperium/h2#530

h2 is used by hyper which is used by reqwuest. This issue is to review our dependencies and evaluate if this (relatively minor) bug is sufficient to consider a different request library.
@ghost ghost changed the title http2 error : protocol error : not a result of an error http2 error from dependency May 24, 2021
@jplevyak
Copy link
Contributor

We should try backing down to HTTP/1.1 or upgrading to newer versions of tokio/hyper/reqwest.

@ninegua
Copy link
Member

ninegua commented Jun 1, 2021

The error could originate either from server or client side. We can't rule out either at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jplevyak @ninegua