Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear spender_subaccount in ICRC-2 #131

Open
sea-snake opened this issue Jul 14, 2023 · 4 comments
Open

Unclear spender_subaccount in ICRC-2 #131

sea-snake opened this issue Jul 14, 2023 · 4 comments

Comments

@sea-snake
Copy link

TransferFromArgs contains spender_subaccount : opt blob in the readme but not in the did file, what is correct? Should it be added to did file or removed from readme?
@MarioDfinity
Copy link
Contributor

In both cases the spender should be an Account. I checked now and it looks like it is. Can you check again?

@sea-snake
Copy link
Author

In both cases the spender should be an Account. I checked now and it looks like it is. Can you check again?

Its missing in transfer from args at: standards/ICRC-2/ICRC-2.did

@MarioDfinity
Copy link
Contributor

Oh I see. Yes it's missing, there should be a spender_subaccount in TransferFromArgs as you said.

@MarioDfinity
Copy link
Contributor

#138 addresses this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarioDfinity @sea-snake