Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use method namespace icrc1_ instead of icrc2_ #106

Open
benjizhai opened this issue Mar 31, 2023 · 0 comments
Open

Use method namespace icrc1_ instead of icrc2_ #106

benjizhai opened this issue Mar 31, 2023 · 0 comments

Comments

@benjizhai
Copy link

I think all standards extending the ICRC-1 standard shall use the namespace icrc1_* for their methods.
Compare the following code snippet when multiple standards are implemented:
icrc2_transfer_from icrc3_get_transactions icrc4_batch_fransfer icrc1_get_metadata
vs
icrc1_transfer_from icrc1_get_transactions icrc1_batch_fransfer icrc1_get_metadata
I would say that the former is very confusing as the developer using the token needs to remember which methods belong to which ICRC number. Where in the latter case as long as the following ICRCs don't have overlapping names (which we can control as part of the ICRC process) it's very easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant