Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict id in cookies_banner_server() #68

Closed
JT-39 opened this issue Dec 11, 2024 · 0 comments · Fixed by #70
Closed

Strict id in cookies_banner_server() #68

JT-39 opened this issue Dec 11, 2024 · 0 comments · Fixed by #70
Assignees

Comments

@JT-39
Copy link
Collaborator

JT-39 commented Dec 11, 2024

Describe the bug

In the code for the function cookies_banner_server() there is a strict id value of navlistPanel which the cookies page of the app must belong to in order for the link "View cookie information" to take you to the page.

How to reproduce

This is the section of the cookies_banner_server() code:

    shiny::observeEvent(input$cookies_link, {
      shiny::updateTabsetPanel(session = parent_session, 
        "navlistPanel", selected = cookies_link_panel)
    })

Fix

It would be useful to either have this as a more flexible id value, or document that the main navigation tabset/navset should have the id value navlistPanel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants