Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make links from footnotes page open in new tab #31

Closed
cjrace opened this issue Aug 14, 2024 · 0 comments · Fixed by #78
Closed

Make links from footnotes page open in new tab #31

cjrace opened this issue Aug 14, 2024 · 0 comments · Fixed by #78
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
End of partnershi...

Comments

@cjrace
Copy link
Contributor

cjrace commented Aug 14, 2024 •
edited
Loading

Can do this ees-ily now by using the dfeshiny::external_link() function - https://dfe-analytical-services.github.io/dfeshiny/reference/external_link.html
@cjrace cjrace converted this from a draft issue Aug 14, 2024
@cjrace cjrace changed the title Make footnotes links open in new tab Make links from footnotes page open in new tab Aug 14, 2024
@cjrace cjrace added the bug Something isn't working label Sep 10, 2024
@cjrace cjrace added the good first issue Good for newcomers label Sep 18, 2024
@cjrace cjrace linked a pull request Oct 1, 2024 that will close this issue
Add a bar chart to page 1 and make footnotes page links open in new tab #78
Merged
4 tasks
@cjrace cjrace mentioned this issue Oct 1, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
End of partnership programme support
1 participant
@cjrace