New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing overflow checking #19

Open

gavinwahl opened this issue Jul 21, 2018 · 1 comment

Labels

bug

gavinwahl commented Jul 21, 2018

It looks like this addition is missing an overflow check: https://github.com/ChristophBerg/postgresql-unit/blob/cf6728e3773e1ff4a1c67f850aa44338405abafe/unit.h#L116

Multiplying values with very high exponents could result in undefined behavior.

Owner

df7cb commented Jul 23, 2018

Right. I'll see to get that fixed.

df7cb added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment