Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dockerize to the docker image #1838

Closed
sagikazarmark opened this issue Oct 18, 2020 · 2 comments · Fixed by #1893
Closed

Add dockerize to the docker image #1838

sagikazarmark opened this issue Oct 18, 2020 · 2 comments · Fixed by #1893
Assignees
@sagikazarmark

Comments

@sagikazarmark
Copy link
Member

Adding dockerize will allow users to use environment variables in config files.
@sagikazarmark sagikazarmark self-assigned this Oct 18, 2020
@lukasmrtvy
Copy link

@sagikazarmark would it not be better to use https://github.com/hairyhenderson/gomplate instead ?

@sagikazarmark
Copy link
Member Author

I don't think it matters much. Dockerize is an established tool for this exact purpose.

@heidemn-faro heidemn-faro mentioned this issue Dec 2, 2020
Closed
@nabokihms nabokihms mentioned this issue Dec 21, 2020
Merged
@sagikazarmark sagikazarmark mentioned this issue Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagikazarmark sagikazarmark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add gomplate to the docker image deckhouse/3p-dex
2 participants
@lukasmrtvy @sagikazarmark