Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Executor] Incorrect functionality of surrounding nodes extractor #65

Open
SaharMehrpour opened this issue May 22, 2024 · 1 comment
Labels

Comments

@SaharMehrpour
Copy link
Member

For the third case of the context-gathering i.e., starting node within method, the update correctly gathers the adjacent fields and methods. But the adjacent methods still contain the bodies, which could lead to more code than we need. I know Sahar you included a removeFunctionBodies method to implement this functionality, so the bug might be there. Or it could be that the example I looked at branched into the first case of static class first (which includes method bodies) because the starting node is in a method in a static class. In this scenario, I believe we would want to still fall into that third category.

Related to PR #59

@SaharMehrpour
Copy link
Member Author

It was keeping all the code in the constructor, which can be helpful. But for some instances it leads to super long code we probably don't need i.e. for Project.java. I think maybe we just say include the first 20 or so lines from the constructor but not beyond that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant