Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Laravel 6.x Support #7

Closed
lorenzoaiello opened this issue Jan 1, 2020 · 6 comments
Closed

Enhancement: Laravel 6.x Support #7

lorenzoaiello opened this issue Jan 1, 2020 · 6 comments

Comments

@lorenzoaiello
Copy link

lorenzoaiello commented Jan 1, 2020

Love the tool, just need Laravel 6.x and Nova 2.x support added.

@vpratfr
Copy link

vpratfr commented Jan 16, 2020

Would be interested about that one too. (and personal access tokens), Is the package still alive?

@Kristories
Copy link
Member

@lorenzoaiello @vpratfr yes. I try to have free time for this.

@raulsh
Copy link
Contributor

raulsh commented Feb 10, 2020

Hi @Kristories. I tried this package with Laravel 6.* and Nova 2.0 and is "working". The only thing that I changed is a line that uses str_random() (I changed to Str::random()). There are known compatibilites issues?

@raulsh
Copy link
Contributor

raulsh commented Feb 11, 2020

@vpratfr @lorenzoaiello I edited a 3 lines to add support for Laravel Nova 2.0 and Laravel 6.0. It seems to work fine with that very small fix. You can use in the meantime our own repo https://github.com/ohysdev/novassport

@Kristories
Copy link
Member

Hi @raulsh thanks for trying it out. Can you make a PR?

@Kristories
Copy link
Member

Fix #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants