Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in legacy loader #208

Open
mackonen opened this issue Sep 8, 2022 · 1 comment
Open

Bug in legacy loader #208

mackonen opened this issue Sep 8, 2022 · 1 comment

Comments

@mackonen
Copy link

mackonen commented Sep 8, 2022

Currently the loader checks for existing script on page with

// If already included in the page:
 if (window.google!== undefined) {
    return Promise.resolve(window.google.charts);
}

unfortunately this doesn't work if you have used other google scripts on the page that are using the google namespace...

this should be instead:

// If already included in the page:
 if (window.google.charts !== undefined) {
    return Promise.resolve(window.google.charts);
}
@mackonen
Copy link
Author

mackonen commented Sep 8, 2022

And short term I'd be open to any ideas how to bypass that bug as we are using other google components.. have been trying to figure out how to override / bypass this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant