feat: cf-375 fullscreen for graphical selector #950
Conversation
There was a problem hiding this comment.
Nice job cleaning up the file structure, I like the look of fullscreen and the drawer! Left a few comments to address, would you also be able to add an index.ts file for the components you've created please (just for consistency's sake) :). Also with the SidebarDrawer, could you push it out to the src/components folder, could be reused in the future. There's also an edge case bug after switching from normal to fullscreen and vice versa then making the browser window bigger, see the video attached. Another small thing to change is that the Tabs could use a little left padding as it looks a bit cramped (i can chuck this into another ticket as it isn't really related to your feature if you want though).
Screen.Recording.2023-01-18.at.11.35.51.pm.mov
|
are there any updates on this? |
also changed some styled component names
added fullscreen for graphical selector.
also split out the graphical selector file because I DIE TRYING TO EDIT THAT!!!
I DIED!
But now it pretty, and clean, and actually dont blow up eslint 🍰
I WOULD LOVE YOUR FEEDBACK ON DESIGN, I DO NOT KNOW IF IT GOOD!!!!!!!!!!!
Circles.Mozilla.Firefox.2022-12-25.00-30-59_Trim.mp4