feat(auth): guest login now forces user to wait before making another guest account #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peedee2002
requested review from
imagine-hussain
and removed request for
imagine-hussain
Peedee2002
force-pushed
the
feat/timeout-guest-login
branch
from
1df798e to
446d617
Compare
Peedee2002
force-pushed
the
feat/timeout-guest-login
branch
from
446d617 to
e4a77e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video demonstrating backend functionality! They can really only reach this if their authentication expires, but i sped this up by making them lose their local storage.
auth.mp4
I did realise that this is confusing for users, so i added a message about this to make it clearer:
I set the timeout to only an hour, let me know if that is too generous.