Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbeliaev: dry run and exception handling #289

Merged
merged 7 commits into from
Oct 6, 2021

Conversation

beliaev-maksim
Copy link
Member

  1. added dry run to functions that support it
  2. redone exception handling and added docs how to proceed. In case of HTTPError we raise ArtifactoryException from HTTPError
    this should ensure clean handling and clear error messages

@allburov
Copy link
Member

DRY part is fine for me.

We could merge it in a different PR

# Conflicts:
#	artifactory.py
# Conflicts:
#	artifactory.py
#	dohq_artifactory/admin.py
@allburov allburov merged commit 37cc72d into devopshq:develop Oct 6, 2021
@beliaev-maksim beliaev-maksim deleted the mbeliaev/copy2 branch October 6, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to run dry-run upload or copy? Need help how to catch exceptions
2 participants