Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to a responsive theme #359

Closed
mattstratton opened this issue May 15, 2016 · 14 comments
Closed

refactor to a responsive theme #359

mattstratton opened this issue May 15, 2016 · 14 comments
Assignees
Labels

Comments

@mattstratton
Copy link
Member

I've actually got a branch in-flight on this, and it shouldn't be too terrible. This will handle #295 and make a lot of things less wonky.

This particular issue will NOT change the overall look and feel of the site, but make things behave a lot better on smaller devices.

@mattstratton mattstratton added this to the Responsive Design milestone May 15, 2016
@mattstratton
Copy link
Member Author

This issue can be the "meta-issue" for tracking smaller issues to get this implemented.

@bridgetkromhout
Copy link
Collaborator

Looking forward to this. Thanks.

@mattstratton mattstratton changed the title refactor to a responsive theme refactor to a responsive theme May 21, 2016
@mattstratton
Copy link
Member Author

mattstratton commented May 31, 2016

We are almost there, folks! Please visit http://workstation.mattstratton.com and see if there are any issues that you think need fixing before we release it (that aren't already listed below).

Please note the following:

Here are the outstanding issues:

(note that #259 is debateable as to whether or not it is blocking in this release; @yvovandoorn really wants it though)

Please note that I'll tag this as a new version once we push this branch with these fixes.

@yvovandoorn
Copy link
Contributor

I do really want it though.

On Tuesday, 31 May 2016, Matt Stratton [email protected] wrote:

We are almost there, folks! Please visit
http://workstation.mattstratton.com and see if there are any issues that
you think need fixing before we release it (that aren't already listed
below).

Please note the following:

Here are the outstanding issues:

(note that #259 #259
is debateable as to whether or not it is blocking in this release;
@yvovandoorn https://github.com/yvovandoorn really wants it though)

Please note that I'll tag this as a new version once we push this branch
with these fixes.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#359 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACkd_w3Mzncu0iNYKMvL8qt6T9rWKpXoks5qHHzpgaJpZM4Ie0Na
.

Yvo van Doorn — Manager, Technical Services (EMEA)

+31 6 38 74 07 46 <+316740746> – [email protected] – *my: *Linkedin
http://www.linkedin.com/in/yvovandoorn/ Twitter
https://twitter.com/yvov

CHEF

CHEF.IO http://www.chef.io/

TM

chef.io http://www.chef.io/ Blog http://www.chef.io/blog/ Facebook
https://www.facebook.com/getchefdotcom Twitter
https://twitter.com/chef Youtube https://www.youtube.com/getchef

@bridgetkromhout
Copy link
Collaborator

I do really want it though.

I don't see this feature that would admittedly be nice to have as a blocker for the release.

@bridgetkromhout
Copy link
Collaborator

bridgetkromhout commented Jun 3, 2016

Here's my edit of the "to do before merging" list as I see it:

- [ ] #441 Welcome page table columns run together (not a release blocker)

- [ ] #423 make a visual break between devopsdays slogan and page title on small viewports (not a release blocker)

- [ ] #259 decouple setting the browser title bar from setting the header text displayed in page (not a release blocker)

@mattstratton
Copy link
Member Author

Also updating the program.md files right?

@bridgetkromhout
Copy link
Collaborator

Also updating the program.md files right?

I updated a bunch of them already. We can re-check them all in the responsive design to make sure they're okay; I'll add that.. I know I did upcoming ones that have no non-stock content, MSP, and SV. Not planning to change past ones.

@bridgetkromhout
Copy link
Collaborator

bridgetkromhout commented Jun 4, 2016

From my POV we just need #485 fixed and after that I think the responsive site is a good enough improvement over what we currently have that we should move on it, despite the several outstanding issues.

@mattstratton
Copy link
Member Author

I agree. The rest of the stuff can be fixed in patches shortly.

@bridgetkromhout
Copy link
Collaborator

bridgetkromhout commented Jun 4, 2016

Added after discussion with @mattstratton:

@bridgetkromhout
Copy link
Collaborator

One last fix - #520 band-aids my constant "where are the upcoming events".

@bridgetkromhout
Copy link
Collaborator

From my POV this meta-issue can be resolved at this point.

@yvovandoorn
Copy link
Contributor

Works for me!

On Saturday, 4 June 2016, Bridget Kromhout [email protected] wrote:

From my POV this meta-issue can be resolved at this point.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#359 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACkd_6BafU8BGbwCUwGaPQW3B9C1Lx2Zks5qIeGmgaJpZM4Ie0Na
.

Yvo van Doorn — Manager, Technical Services (EMEA)

+31 6 38 74 07 46 <+316740746> – [email protected] – *my: *Linkedin
http://www.linkedin.com/in/yvovandoorn/ Twitter
https://twitter.com/yvov

CHEF

CHEF.IO http://www.chef.io/

TM

chef.io http://www.chef.io/ Blog http://www.chef.io/blog/ Facebook
https://www.facebook.com/getchefdotcom Twitter
https://twitter.com/chef Youtube https://www.youtube.com/getchef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants