#734: Improve Process Result Model #773
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/alfeilex/IDEasy into devonfw#734-improve-process-result
alfeilex
commented
Nov 19, 2024
| */ | ||
| public record LogEvent(boolean error, String message) { | ||
|
|
||
| } |
There was a problem hiding this comment.
Should it be located in the process or log package or elsewhere?
alfeilex
commented
Nov 19, 2024
| CompletableFuture<List<String>> outFut = readInputStream(process.getInputStream()); | ||
| CompletableFuture<List<String>> errFut = readInputStream(process.getErrorStream()); | ||
| CompletableFuture<List<String>> outFut = readInputStream(process.getInputStream(), false, logs); | ||
| CompletableFuture<List<String>> errFut = readInputStream(process.getErrorStream(), true, logs); | ||
| out = outFut.get(); | ||
| err = errFut.get(); |
There was a problem hiding this comment.
Should we remove out and err and keep all the logs in a single list of LogEvent? If so, we will need to refactor ProcessResult as well, right?
alfeilex
commented
Nov 19, 2024
| synchronized (logs) { | ||
| LogEvent logEvent = new LogEvent(errorStream, line); | ||
| logs.add(logEvent); | ||
| } |
There was a problem hiding this comment.
I am not sure, if I am using LogEvent correctly. In this implementation, a single LogEvent instance represents one line from either stout or sterr. I don't see another solution to capture the entire log while keeping the order of the log streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #734