#415: log command before sudo pw #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method that will inform the user for what process he will need to enter his root-password
Pull Request Test Coverage Report for Build 11782731350Details
💛 - Coveralls |
hohwille
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
@leonrohne27 thanks for your PR. Your solution should already work slightly 👍
However, I left some comments for improvement since you are logging too much information what will confuse or mislead the user.
Since I am sure, you will rework this easily, I already approve so if the review comments are resolved, we can merge this.
cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
Outdated
Show resolved
Hide resolved
Changed logPackageManagerCommands so that it only prints out the output for the single PackageManagerCommand that will be executed
hohwille
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
@leonrohne27 thanks for your rework. Now perfect 👍
Ready for merge.
hohwille
reviewed
Nov 4, 2024
cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
Outdated
Show resolved
Hide resolved
hohwille
added
the
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #415
implements: