Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#720: Put IDEasy-contribution-getting-started doc up-to-date. #721

Merged
merged 14 commits into from
Nov 1, 2024
Merged

#720: Put IDEasy-contribution-getting-started doc up-to-date. #721

merged 14 commits into from
Nov 1, 2024

Conversation

nmCapG
Copy link
Contributor

@nmCapG nmCapG commented Oct 29, 2024

Fixes #720. Put some information up-to-date in ./documentation/IDEasy-contribution-getting-started doc.

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jan-vcapgemini
jan-vcapgemini requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your corrections. I've added some small change requests.

documentation/IDEasy-contribution-getting-started.adoc Outdated Show resolved Hide resolved
documentation/IDEasy-contribution-getting-started.adoc Outdated Show resolved Hide resolved
documentation/IDEasy-contribution-getting-started.adoc Outdated Show resolved Hide resolved
documentation/IDEasy-contribution-getting-started.adoc Outdated Show resolved Hide resolved
documentation/IDEasy-contribution-getting-started.adoc Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Oct 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11630492391

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.917%
Totals Coverage Status
Change from base Build 11611407607: 0.0%
Covered Lines: 6303
Relevant Lines: 9076
💛 - Coveralls

@jan-vcapgemini jan-vcapgemini marked this pull request as ready for review October 30, 2024 10:03
@jan-vcapgemini jan-vcapgemini added the documentation Improvements or additions to documentation label Oct 30, 2024
@jan-vcapgemini jan-vcapgemini self-assigned this Oct 30, 2024
jan-vcapgemini
jan-vcapgemini approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the permanent links. Ready for review.

hohwille
hohwille approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmCapG thanks for your PR. Very nice job with many fixes and improvements 👍
Ready for merge!

@hohwille hohwille added this to the release:2024.11.001 milestone Nov 1, 2024
@hohwille hohwille merged commit 881c978 into devonfw:main Nov 1, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

@hohwille hohwille hohwille approved these changes

Assignees

@jan-vcapgemini jan-vcapgemini

@nmCapG nmCapG

Labels
documentation Improvements or additions to documentation reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.11.001
Development

Successfully merging this pull request may close these issues.

Put IDEasy-contribution-getting-started documentation up to date.
6 participants
@nmCapG @CLAassistant @coveralls @hohwille @jan-vcapgemini @devonfw-core