Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#215: encoding error with graalvm #246

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

diiinesh
Copy link
Contributor

Fixes #215

@diiinesh diiinesh self-assigned this Mar 11, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8325649613

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.487%

Totals Coverage Status
Change from base Build 8325462603: 0.0%
Covered Lines: 4064
Relevant Lines: 6696

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diiinesh thanks for your PR. Your approach seems to make sense since we are using an old version of graalvm and the encoding bug was fixed already. 👍
As this PR is still in draft mode, I assume you are still testing.
I already approve so once you take out of draft, we can merge and test this.

@diiinesh diiinesh marked this pull request as ready for review March 18, 2024 11:18
@hohwille hohwille merged commit 128bf5c into devonfw:main Mar 18, 2024
4 checks passed
@hohwille hohwille changed the title encoding error with graalvm #215: encoding error with graalvm Mar 18, 2024
@hohwille hohwille added this to the release:2024.03.001 milestone Mar 18, 2024
@hohwille hohwille added release related to release commandlet and releases of IDEasy native-image GraalVM native image of IDEasy CLI (e.g. for bugs that only happen in binary of CLI) bugfix labels Mar 18, 2024
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@tobka777 tobka777 added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix native-image GraalVM native image of IDEasy CLI (e.g. for bugs that only happen in binary of CLI) release related to release commandlet and releases of IDEasy reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Encoding bug with i18n of help
4 participants