-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#132: untar preserves unix file permissios #185
#132: untar preserves unix file permissios #185
Conversation
also wrote a test for untar. Unzip still does not preserve file permissions
Pull Request Test Coverage Report for Build 7667343336
💛 - Coveralls |
Currently, zip archives are unpacked using So either we refactor the |
- removed the code I experimented with regarding the Zip extraction, which will probably get addressed in a different PR. - the tar extraction tests now test NONE, GZ, and BZIP2 compression
…esnt-preserve-file-permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MattesMrzik Thanks for this PR. Great work. You nailed it from the start. 👍
Ready for merge.
@MattesMrzik now the workaround (was it in |
Not yet. Aws uses zip instead of tar and permissions are not yet conserved when extracting zip on unix. |
Partly fixes #132.
The untar bug of #132 is fixed. Unzipping while preserving file permissions is still missing.
Also wrote a test for untar.