-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10: improve IDE support and configure workspace #135
Conversation
…gurator refactoring, bugfix with newContext and copy
cli/src/main/java/com/devonfw/tools/ide/environment/AbstractEnvironmentVariables.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/merge/DirectoryMerger.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/merge/PropertiesMerger.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/variable/VariableDefinition.java
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/merge/DirectoryMergerTest.java
Outdated
Show resolved
Hide resolved
string concatenation replaced with inline variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've added some typo fixes and fixed log messages.
Please check the questions I've added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've added some typo fixes and fixed log messages.
Please check the questions I've added.
@jan-vcapgemini thank you very much for your review and your constructive fixes of my typos and the log-statements I missed out to align. All your changes are correct and improve the code quality. 👍 |
@jan-vcapgemini I finally found some minutes to address your review-comments. |
Implements most of #10:
IdeToolCommandlet
so workspace gets auto-configured before IDE is startedAbstractIdeContextTest.newContext(String, String, boolean)
:IdeContext
was created in original location and not in the copy - henceVersionSetCommandletTest
was modifying git managed file (undesired side effect).File
occurrences withPath
IdeContext
(otherwise workspace configuration is not working if paths are relative)EnvironmentVariablesResolved
toEnvironmentVariables
API