Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10: improve IDE support and configure workspace #135

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Nov 8, 2023

Implements most of #10:

  • completely refactored configurator (only little left of the original code)
  • integrated configurator into IdeToolCommandlet so workspace gets auto-configured before IDE is started
  • pass proper arguments to eclipse
  • show project name in eclipse title-bar (instead of workspace that is already shown be default)
  • check if eclipse workspace is locked
  • fixed bug in AbstractIdeContextTest.newContext(String, String, boolean): IdeContext was created in original location and not in the copy - hence VersionSetCommandletTest was modifying git managed file (undesired side effect).
  • improved some tests
  • replace last File occurrences with Path
  • normalize paths in String representation (replace backslash with slash)
  • make paths absolute in IdeContext (otherwise workspace configuration is not working if paths are relative)
  • moved logic to resolve variables from EnvironmentVariablesResolved to EnvironmentVariables API

…gurator refactoring, bugfix with newContext and copy
@hohwille hohwille added vscode Microsoft visual studio code eclipse related to Eclipse IDE intellij IntelliJ IDE from Jet-Brains workspace labels Nov 8, 2023
@hohwille hohwille added this to the release:2024.01.001 milestone Nov 8, 2023
@hohwille hohwille linked an issue Nov 8, 2023 that may be closed by this pull request
string concatenation replaced with inline variables
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I've added some typo fixes and fixed log messages.
Please check the questions I've added.

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I've added some typo fixes and fixed log messages.
Please check the questions I've added.

@hohwille
Copy link
Member Author

hohwille commented Nov 9, 2023

@jan-vcapgemini thank you very much for your review and your constructive fixes of my typos and the log-statements I missed out to align. All your changes are correct and improve the code quality. 👍

@hohwille
Copy link
Member Author

@jan-vcapgemini I finally found some minutes to address your review-comments.
Please check and see if we can resolve the remaining conversations and finally merge this.

@hohwille hohwille merged commit 489c8d6 into devonfw:main Nov 16, 2023
3 checks passed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@hohwille hohwille self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eclipse related to Eclipse IDE intellij IntelliJ IDE from Jet-Brains story-review marks PRs that will be presented in the sprint-review vscode Microsoft visual studio code workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create support for IDEs
2 participants