Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Again messages break processable command output #754

Closed
hohwille opened this issue Nov 12, 2024 · 2 comments · Fixed by #755 or #777
Closed

Again messages break processable command output #754

hohwille opened this issue Nov 12, 2024 · 2 comments · Fixed by #755 or #777
Assignees
Labels
bug Something isn't working core FileAccess, ProcessUtil, IdeContext, etc. environment EnvironmentCommandlet, env variables, path, etc. logging

Comments

@hohwille
Copy link
Member

$ ide -v
Duplicate variable definition MVN_VERSION with old value '0.1' and new value '3.9.6' in D:\projects\salog\settings\devon.properties
Both legacy variable MAVEN_VERSION and official variable MVN_VERSION are configured in D:\projects\salog\settings\devon.properties - ignoring legacy variable declaration!
2024.11.001-beta-SNAPSHOT
bash: $'\E[93mDuplicate': command not found
bash: $'\E[93mBoth': command not found

See #627 and #531.
This error was introduce by me with PR #746

Adding a log warning to some reasonable place should not lead to this error.

It is not acceptable that before adding a log warning you always have to understand if that may be triggered during context initialization since this way this error will come back again and again.

We need to find a way to finally fix this problem once and forever!

@hohwille hohwille added bug Something isn't working environment EnvironmentCommandlet, env variables, path, etc. logging core FileAccess, ProcessUtil, IdeContext, etc. labels Nov 12, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Nov 12, 2024
@hohwille hohwille self-assigned this Nov 12, 2024
@hohwille hohwille moved this from 🆕 New to 🏗 In progress in IDEasy board Nov 12, 2024
hohwille added a commit to hohwille/IDEasy that referenced this issue Nov 12, 2024
@hohwille hohwille modified the milestone: release:2024.11.001 Nov 14, 2024
hohwille added a commit that referenced this issue Nov 15, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Nov 15, 2024
@hohwille
Copy link
Member Author

was auto-closed by PR. But still a bullet-proof solution is needed.
Hence reopening...

@hohwille hohwille reopened this Nov 15, 2024
@hohwille
Copy link
Member Author

hohwille commented Nov 18, 2024

Still buggy after merging PR #755

$ ide
bash: Skipping: command not found
IDE environment variables have been set for /d/projects/IDEasy in workspace main

Problem was this message:

this.context.info("Skipping the cloning of project repositories as specified by the user.");

This one is interesting since this message is also in info level.
IMHO we need to invent our own log-level for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core FileAccess, ProcessUtil, IdeContext, etc. environment EnvironmentCommandlet, env variables, path, etc. logging
Projects
Status: ✅ Done
1 participant