Xml merger ID fallback not working

[hohwille]

Expected behavior

See #43, #403 etc. We specified the ID fallback as following:
https://github.com/devonfw/IDEasy/blob/main/documentation/configurator.adoc#element-identification

Actual behavior

The implementation is wrong and never tested:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/merge/xmlmerger/matcher/ElementMatcher.java

Lines 56 to 71 in f296ef9

	if (id.isEmpty()) {
	// handle case where element has no attribute
	if (sourceElement.getElementAttributes().isEmpty()) {
	// use name as id
	id = sourceElement.getElement().getLocalName();
	} else {
	// look for id or name attributes
	String idAttr = sourceElement.getElement().getAttribute("id");
	if (idAttr.isEmpty()) {
	idAttr = sourceElement.getElement().getAttribute("name");
	if (idAttr.isEmpty()) {
	throw new IllegalStateException(
	"No merge:id value defined for element " + sourceElement.getXPath() + " in document " + sourceElement.getDocumentPath());
	}
	}
	}

While it tries to handle the cases it does not actually initialize a fallback at all and IMHO the only fallback for the name is incorrect.

Steps to reproduce (bug) / Use Case of feature request (enhancement)

1. write a XML template and omit merge:id attributes for elements that have name or id attribute
2. run the XML merger on that

Related/Dependent Issues

#403

Comments/Hints:

As stated above the fallback needs to be name(), @id or @name according to the attribute presence.

Affected version:

• latest 2024.09.002-beta-SNAPSHOT