Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows paths support #22

Open
bonesoul opened this issue Nov 6, 2015 · 4 comments
Open

add windows paths support #22

bonesoul opened this issue Nov 6, 2015 · 4 comments

Comments

@bonesoul
Copy link

bonesoul commented Nov 6, 2015

doesnt work on windows!

path.js:8                                                                                                      
    throw new TypeError('Path must be a string. Received ' +                                                   
    ^                                                                                                          

  TypeError: Path must be a string. Received [ 'E:\\Coding\\hypetrain\\src\\views'                             
   ]                                                                                                           

  - path.js:8 assertPath                                                                                       
    path.js:8:11                                                                                               

  - path.js:221 Object.win32.join                                                                              
    path.js:221:5                                                                                              

  - index.js:12 getPath                                                                                        
    [hypetrain]/[express-debug]/lib/panels/template/index.js:12:21                                             

  - index.js:29 Object.module.exports.process                                                                  
    [hypetrain]/[express-debug]/lib/panels/template/index.js:29:34                                             

  - index.js:85 Object.panels.render                                                                           
    [hypetrain]/[express-debug]/lib/panels/index.js:85:32                                                      

  - response.js:70 render_toolbar                                                                              
    [hypetrain]/[express-debug]/lib/response.js:70:37                                                          


@devoidfury
Copy link
Owner

It looks like it was expecting a string and got an array. Thanks for the report, will fix!

@bonesoul
Copy link
Author

hopefully when? :)

@bonesoul
Copy link
Author

any updates on this?

@devoidfury
Copy link
Owner

I haven't had time to do active maintenance lately. If you'd like to submit a PR I'd be happy to pull it in and push a new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants