Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express 4.x support #11

Open
uiii opened this issue Apr 16, 2014 · 8 comments
Open

Express 4.x support #11

uiii opened this issue Apr 16, 2014 · 8 comments

Comments

@uiii
Copy link

uiii commented Apr 16, 2014

Hi, it would be great to support Express 4.x.

@devoidfury
Copy link
Owner

Thanks for the report!

This weekend I'll check to see if any forks have started on 4.x support, and if not, I'll knock it out.

@devoidfury
Copy link
Owner

Basic support for 4.x included in the latest release (1.1.0), with everything but the profile panel.

Let me know if you have any feedback!

@Offirmo
Copy link

Offirmo commented May 15, 2014

Hello, this looks nice. I'm trying with express 4. Could you update the documentation ?

app.configure('development', function() {
    ^
TypeError: Object function (req, res, next) {
    app.handle(req, res, next);
  } has no method 'configure'

@devoidfury
Copy link
Owner

Good call, thanks. It's updated on the master version readme.

@Offirmo
Copy link

Offirmo commented May 15, 2014

And it works ! Express 4.2 latest. At /express-debug only, though.

My application serves an index.html (via express.static). Care to explain the conditions for the debug tab integration ?

@devoidfury
Copy link
Owner

The tab will only show when render is called in a route, usually when using a template engine. There isn't a clean way to inject into express.static served files, as far as I'm aware.

@Offirmo
Copy link

Offirmo commented May 16, 2014

Ok. I haven't been able to make my dust render work yet.

Express 4.2 validation : OK from me.

Thanks !

@Offirmo
Copy link

Offirmo commented Oct 5, 2014

As a note : everything is fine now, EDT gest integrated in my template pages.

Maybe we could close this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants