Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for new simplecov results #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for new simplecov results #6

wants to merge 1 commit into from

Conversation

szechyjs
Copy link

@szechyjs szechyjs commented Mar 30, 2021 •
edited
Loading

Bug fix

Description

Simplecov changed the .last_run.json file.

Fixes #5

Also fixed a spelling typo.

Why should this be added

Without this the action errors:

/action/lib/report_adapter.rb:10:in `conslusion': undefined method `>=' for nil:NilClass (NoMethodError)
	from /action/lib/github_check_run_service.rb:20:in `run'
	from /action/lib/index.rb:29:in `<main>'

Checklist

  • My code follows the style guidelines of this project
  • Actions are passing

ericboehs
ericboehs approved these changes Mar 31, 2021
View reviewed changes
Copy link

@ericboehs ericboehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Supports old and new syntax.

@joshmfrankel
Copy link

joshmfrankel commented Feb 18, 2022 •
edited
Loading

This fixes the /action/lib/report_adapter.rb:10:in conslusion': undefined method >=' for nil:NilClass though I'm not seeing the screenshots as part of the Github Action output. Does anyone know if that still works?

Is it perhaps to do with permissions or private repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericboehs ericboehs ericboehs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What formatter to use for SimpleCov
3 participants
@szechyjs @joshmfrankel @ericboehs