-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VerifySet breaks with System.NullReferenceException for WriteOnly-Indexed-Properties #1036
Comments
Hi @Epicycle23 , thanks for reporting. I'll take a look a little later. |
OK, this broke between versions 4.10.1 and 4.11.0, and the problem lies in this line of code: This is supposed to extract the method from the expression tree, and obviously always choosing the getter won't do any good for write-only indexers. For regular properties, we have a different code path that accounts for the write-only special case: However, splitting assignment expressions and both code paths mentioned above need some improving, they're rather hard to understand. I'll see what I can come up with. |
OK, this should be fixed. The expression tree logic I had to change is somewhat difficult to understand, so I might do some refactoring before releasing a bugfix version on NuGet. It should happen sometime during the next few days. Thanks again for reporting this regression! |
Thanks for the fast response/fix, can't wait to update. |
Update: Version 4.14.5 should become available on NuGet shortly.
|
Version: 4.14.4
Language: Visual Basic
Environment: Visual Studio 2019 16.6.2
Steps to reproduce
Was working fine with version 4.8.3.
I ran into this issue when trying to update to 4.14.4
The text was updated successfully, but these errors were encountered: