Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm remaining unsued concepts #256

Closed
dw8547 opened this issue Feb 27, 2017 · 10 comments
Closed

Confirm remaining unsued concepts #256

dw8547 opened this issue Feb 27, 2017 · 10 comments
Assignees

Comments

@dw8547
Copy link
Collaborator

dw8547 commented Feb 27, 2017

Hi @epicallan, I need your help with this one. I can't figure out for sure (using the DH web app source code) if these are used or not:

  1. dfis-out: string found in components/AreaTree/areaTreeDirective.js & pages/Country/country_print.html
  2. dfis-out-dev: string found in components/AreaTree/areaTreeDirective.js
  3. ethiopia-nigeria-r3: string found in charts/angular/chartjs.js
  4. ethiopia-nigeria-r7: string found in charts/angular/chartjs.js & pages/debug/debug.html
  5. fdi-out: string found in components/AreaTree/areaTreeDirective.js, components/TreeChart/treeChartInternationalDirective.js, pages/Country/country_print.html, charts/angular/chartjs.js
  6. in-oof-net: string not found anywhere in the DH web app source code
  7. long-debt-disbursement-in: string found in components/AreaTree/areaTreeDirective.js
  8. long-debt-net-official-in: string found in components/AreaTree/areaTreeDirective.js
  9. oda-capital-repayments: string found in components/AreaTree/areaTreeDirective.js
  10. oda-interest-payments: string found in [components/AreaTree/areaTreeDirective.js](https://github.com/devinit/datahub-angular/public/diConcept/components/AreaTree/areaTreeDirective.js
  11. remittances: string found in several locations
  12. ssc-out: string found in components/AreaTree/areaTreeDirective.js

Please confirm if OK to remove from concepts.csv.

@dw8547
Copy link
Collaborator Author

dw8547 commented Mar 27, 2017

Hi @malmike, @epicallan said you could help out with this tomorrow morning.

@dw8547
Copy link
Collaborator Author

dw8547 commented Mar 28, 2017

Good morning @malmike, I'm ready when you are.

@malmike
Copy link
Contributor

malmike commented Mar 28, 2017

Afternoon @dw8547, Sorry went directly into checking whether the items above were being used.

@dw8547
Copy link
Collaborator Author

dw8547 commented Mar 28, 2017

Thanks @malmike! Please keep me posted :)

@malmike
Copy link
Contributor

malmike commented Mar 28, 2017

I have been told that most of them are used in data retrieval by the data service file. And on cross checking whether they were being utilized, I got the following result:-
1 - Not used; Ran the country print page and the country profile page;
2 - Not used; Ran the country print page and the country profile page;
3 - Not used; Ran the country print page for ethopia, nigeria and united kingdom;
4 - Not used; Ran the country print page for ethopia, nigeria and united kingdom;
5 - Not used; Ran the country print page and the country profile page;
6 - Not fount in the DH web application source code;
7 - Not used; Ran the country profile page and the country print page;
8 - Not used; Ran the country print page and the country profile page;
9 - Not used; Ran the country print page and the country profile page;
10 - Not used; Ran the country print page and the country profile page;
11 - Appears to be used;
12 - Not used; Ran the country print page and the country profile page;

@malmike
Copy link
Contributor

malmike commented Mar 28, 2017

The reason I was mainly running the country profile or country print page is because the directives or components that were mentioned above would require either one or both of those pages to be loading in order to run

@dw8547
Copy link
Collaborator Author

dw8547 commented Mar 28, 2017

Thank you @malmike. Will remove 1 - 10 & 12. Out of curiosity, which chart is 11 used with?

@malmike
Copy link
Contributor

malmike commented Mar 28, 2017

Remittances is not applied as it is, what I found was remittances-individual-devcountries and that is found in country print of donor countries. Am not sure if that is in relation to the initial query, 'remittances: string found in several locations'.

@dw8547
Copy link
Collaborator Author

dw8547 commented Mar 28, 2017

Thanks @malmike. What I'm after really is if the web app data model at any point takes from remittances.csv (or any of the other files that use the names from the list above + .csv). If not, I want to delete the file(s) as it's clutter & @epicallan says this slows down the web app. If you haven't found a reference to 'remittances' on it's own, I presume it's OK to delete. Many thanks.

@dw8547
Copy link
Collaborator Author

dw8547 commented Mar 30, 2017

d7f7b63.

@dw8547 dw8547 closed this as completed Mar 30, 2017
dw8547 added a commit that referenced this issue Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants