fix skipping to the wrong song #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devgianlu Would be great if you would give some tips for refactoring the second commit 😄 |
devgianlu
requested changes
Aug 17, 2024
|
Can you rebase and add the missing parameter |
devgianlu
approved these changes
Aug 18, 2024
|
Mhh, this does not look right. You should be able to |
|
I thought this is what I did, I'll just start from the beginning and fp then 👍 |
thilojaeggi
pushed a commit
to thilojaeggi/go-librespot
that referenced
this pull request
Oct 13, 2024
* feat: implement skip to track-index * feat: implement skipping in play queue * chore: simplification and refactoring * chore: inline tracks * chore: add drop parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st fix: On the recommended section below a playlist owned by the user, skipping to any song played the first song only.
2nd fix: While skipping in the queue, it only ever skips one song forward.